Allow Separate Store Session Expiration Option#85
Open
mullen3 wants to merge 4 commits intoroidrage:masterfrom
Open
Allow Separate Store Session Expiration Option#85mullen3 wants to merge 4 commits intoroidrage:masterfrom
mullen3 wants to merge 4 commits intoroidrage:masterfrom
Conversation
…e_after_option Adds option to have separate session and cookie expiration options
Author
|
Ah it looks like a similar feature was proposed in #84. Do the maintainers have a preference between the two options and implementations? |
Author
|
@roidrage @meatballhat Friendly bump. I'm happy to fix the RuboCop style issues if the maintainers have interest in this feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds an option that allows you to specify a separate timeout for the expiration of the session in redis than the expiration set on the cookie. This flexibility allows you to use a transient cookie that still expires if the browser is left open.
I have also added a few specs for the different expiration scenarios.