Reduce exists command by loading from private_id first#148
Open
hogelog wants to merge 1 commit intoroidrage:masterfrom
Open
Reduce exists command by loading from private_id first#148hogelog wants to merge 1 commit intoroidrage:masterfrom
hogelog wants to merge 1 commit intoroidrage:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current redis-session-store has been implemented to throw the exists command to redis twice.
redis-session-store/lib/redis-session-store.rb
Line 68 in 21c576d
redis-session-store/lib/redis-session-store.rb
Line 124 in 21c576d
With this PR implementation, a session that has not been migrated to private_id will throw get commands to private_id and public_id twice. But migrated session will only get once, which I think is more efficient.