Add retry monitoring for reminder jobs#1030
Open
darshan-Jahagirdar wants to merge 1 commit into
Open
Conversation
Author
|
Validation update for this PR: Result: both passed locally. I also tried the full backend pytest suite in a temporary Python 3.11 virtualenv with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
last_errorprocessed,sent,failed, andretriesfrom/reminders/runCloses #130
Validation
py -3.11 -m venv .venv-backend-test.\.venv-backend-test\Scripts\python.exe -m pip install -r packages\backend\requirements.txtpackages/backend:..\..\.venv-backend-test\Scripts\python.exe -m pytest tests\test_reminders.py -q -k run_due->2 passed, 2 deselectedpackages/backend:..\..\.venv-backend-test\Scripts\python.exe -m black --check app\config.py app\__init__.py app\models.py app\observability.py app\services\jobs.py app\routes\reminders.py tests\test_reminders.pypackages/backend:..\..\.venv-backend-test\Scripts\python.exe -m flake8 app\config.py app\__init__.py app\models.py app\observability.py app\services\jobs.py app\routes\reminders.py tests\test_reminders.pypython -m py_compile packages\backend\app\config.py packages\backend\app\__init__.py packages\backend\app\models.py packages\backend\app\observability.py packages\backend\app\services\jobs.py packages\backend\app\routes\reminders.py packages\backend\tests\test_reminders.pygit diff --checkNote: running the entire existing
tests/test_reminders.pymodule locally requires Redis for the pre-existingauth_headerfixture; the new retry tests avoid Redis by minting JWTs directly and passed in the local environment./claim #130