feat: centralized event emitter with save/load/navigate hooks (#129)#132
Merged
Conversation
…vigate hooks (#129) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… event (#129) BREAKING CHANGE: Story.on('navigate') removed — use Story.on('afternavigate')
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ntCallback (#129) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Release preview: merging this PR will publish v0.41.0 (minor bump from v0.40.1) |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/event-emitter.ts— a typed centralized event emitter replacing scattered listener arrays acrossstore.ts,action-registry.ts, andstory-api.tsbeforesave,aftersave,beforeload,afterload,beforenavigate,afternavigate— enabling host apps to inject behavior around these operations without monkey-patchingStory.on()to a type-safe thin wrapper delegating to the emitterBREAKING CHANGE:
Story.on('navigate')removed — useStory.on('afternavigate')(same callback signature).afternavigateonly fires from explicit navigation (navigate(),goBack(),goForward()), not fromloadFromPayload().Closes #129
Test plan
tsc --noEmitclean🤖 Generated with Claude Code