feat: auto-clean Story.on() handlers on restart (#128)#130
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Every event branch in Story.on() now captures the unsub function and passes it to trackRuntimeUnsub() so handlers registered during the runtime phase are automatically cleaned on restart. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Release preview: merging this PR will publish v0.40.0 (minor bump from v0.39.1) |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trackRuntimeUnsub,enterRuntimePhase) tostore.ts— handlers registered viaStory.on()afterexecuteStoryInit()are automatically unsubscribed whenrestart()runsStory.on()(navigate, beforerestart, storyinit, actionsChanged, variableChanged) to calltrackRuntimeUnsubenterRuntimePhase()beforeexecuteStoryInit()in both boot (index.tsx) and restart (store.ts) pathsFixes #128
Design
Handlers registered during
:storystartup(startup phase) survive restarts. Handlers registered fromexecuteStoryInit()onwards (runtime phase) are auto-cleaned on restart, afterfireBeforeRestart()fires but before state resets. This prevents duplicate handler accumulation when host apps re-register duringstoryinit.Test plan
trackRuntimeUnsubis a no-op beforeenterRuntimePhaseStory.on()beforerestarthandler fires before being cleaned🤖 Generated with Claude Code