fix: preserve renderDeferred set during beforerestart handler#127
Merged
Conversation
restart() unconditionally reset renderDeferred to false, overriding any Story.deferRender() call made in a beforerestart handler. Now resets renderDeferred before firing callbacks so it can detect if a handler set it back to true, and preserves that state through the restart. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Release preview: merging this PR will publish v0.39.1 (patch bump from v0.39.0) |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
restart()unconditionally setrenderDeferred = false, overriding anyStory.deferRender()call made in abeforerestarthandlerrenderDeferredbefore firing callbacks, then checks if a handler set it back totrueand preserves that state through the restartStoryLoadingwhile an engine rebuilds)Closes #126
Test plan
restart() preserves renderDeferred if set during beforerestartrestart() resets renderDeferred to false(no handler) still passes🤖 Generated with Claude Code