Skip to content

fix: start and end methods #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rogervila merged 1 commit into from
Mar 4, 2026
Merged

fix: start and end methods #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions python_carbon/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,8 +561,10 @@ def endOfDay(self) -> 'Carbon':
)

def startOfWeek(self) -> 'Carbon':
start_of_week = self._date - timedelta(days=self._date.weekday())

return Carbon(
(self._date - timedelta(days=self._date.weekday())).replace(
start_of_week.replace(
hour=0,
minute=0,
second=0,
Expand All @@ -571,8 +573,10 @@ def startOfWeek(self) -> 'Carbon':
)

def endOfWeek(self) -> 'Carbon':
end_of_week = self.startOfWeek().toDatetime() + timedelta(days=6)

return Carbon(
self.startOfWeek().addDays(6).toDatetime().replace(
end_of_week.replace(
hour=23,
minute=59,
second=59,
Expand Down Expand Up @@ -604,7 +608,7 @@ def endOfMonth(self) -> 'Carbon':

def startOfYear(self) -> 'Carbon':
return Carbon(
self.startOfWeek().addDays(6).toDatetime().replace(
self._date.replace(
month=1,
day=1,
hour=0,
Expand All @@ -616,7 +620,7 @@ def startOfYear(self) -> 'Carbon':

def endOfYear(self) -> 'Carbon':
return Carbon(
self.startOfWeek().addDays(6).toDatetime().replace(
self._date.replace(
month=12,
day=31,
hour=23,
Expand Down
12 changes: 12 additions & 0 deletions tests/test_python_carbon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,18 @@ def test_start_and_end_methods(self) -> None:
self.assertEqual(end_of_hour.second, 59)
self.assertEqual(end_of_hour.microsecond, 999999)

def test_start_end_week_and_year_exact_values(self) -> None:
dt = Carbon.parse('2021-08-18 14:15:16.123456')

self.assertEqual(dt.startOfWeek().toDateTimeString(with_milliseconds=True), '2021-08-16 00:00:00.000000')
self.assertEqual(dt.endOfWeek().toDateTimeString(with_milliseconds=True), '2021-08-22 23:59:59.999999')
self.assertEqual(dt.startOfYear().toDateTimeString(with_milliseconds=True), '2021-01-01 00:00:00.000000')
self.assertEqual(dt.endOfYear().toDateTimeString(with_milliseconds=True), '2021-12-31 23:59:59.999999')

sunday = Carbon.parse('2021-08-22 10:00:00')
self.assertEqual(sunday.startOfWeek().toDateTimeString(), '2021-08-16 00:00:00')
self.assertEqual(sunday.endOfWeek().toDateTimeString(), '2021-08-22 23:59:59')

def test_add_sub_and_last_day_of_month(self) -> None:
self.assertTrue(Carbon.parse('2021-08-31').isLastDayOfMonth())

Expand Down