Improve prpack CLI import safety#2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
dist/src/cli.jsno longer runsprpack generateas a side effect.runis exported, and verifies noPR_PACK.mdis created.Why it matters
Prpack exports its CLI runner for automation and tests. Import-time side effects can surprise toolchains, create files in the caller's working directory, and make programmatic use less trustworthy.
Verification
npm ci && npm run check && npm test && npm run smoke && npm run release:check— passed.Remaining limitations / follow-up
0.1.0; a future PR could read it from package metadata like the library export path does.