Fix RTAI build: M_PI_2 undeclared#11
Merged
rodw-au merged 1 commit intorodw-au:state-tags-arcsfrom May 3, 2026
Merged
Conversation
M_PI_2 is a glibc extension and is not exposed by RTAI's rtapi_math.h, so the RTAI build fails with 'M_PI_2 undeclared' at control.c:2283. M_PI is available in both, so use M_PI/2.0 instead.
rodw-au
approved these changes
May 3, 2026
Owner
rodw-au
left a comment
rodw-au
left a comment
There was a problem hiding this comment.
should work we already use M_PI in interp_convert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LinuxCNC PR LinuxCNC#3995's RTAI job fails:
M_PI_2is a glibc/_GNU_SOURCEextension that is not exposed by RTAI'srtapi_math.h.M_PIis available in both, so replaceM_PI_2withM_PI / 2.0in the two G2/G3 heading lines.Test plan