Conversation
9f22550 to
bf39929
Compare
ee0b0b5 to
7d14248
Compare
7d14248 to
8008652
Compare
MSoegtropIMC
approved these changes
Jan 8, 2021
Collaborator
MSoegtropIMC
left a comment
There was a problem hiding this comment.
Except for the editorial comments, this looks good to me. Thanks!
492cacd to
6215d80
Compare
Member
Author
|
This is finally ready. I'll merge it and ask for testing. The package in online, although not listed in the search engine. |
Closed
Member
|
When github/roadmap#167 is implemented (excepted before the end of March), it should help to deploy from a CI run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request for aliases (coqide and coq_makefile) is ongoing here: https://forum.snapcraft.io/t/aliases-request-for-coq-prover/21925
@MSoegtropIMC this is now ready for review. There are a few things to document:
github_actions/run_snap.shcan do it. The idea is that the job is run "in full" only when one wants to upload to the store, otherwise a minimal (quicker) thing is build but not uploaded. Saving the artifact is orthogonal to uploading to the store. Uploading to the store does not make the snap public, there is a pipeline (I still have to test) to move fromedgetobetaand then tostablea package by hand. So it is not the end of the world if one uploads by mistake, but it is just a waste I believe.A few point to discuss:
linux/create_linux_installer.shbut alsosnap/containing templates and the result of calling the first script, is it ok? In general this PR creates 3 directories, maybe it's too much.Improvements we could do:
The package is still private, here a preview:
