Skip to content

Conversation

@cschow-ucsd
Copy link
Contributor

  • Providers to provide singleton input/output devices
  • Remove getInstance() methods in most classes, in favor of initializing all objects in FlightComputer
  • Builder pattern to construct customized FlightComputer instances

Partially addresses #52, but returning different sensors/simulators has not been completed in SensorProvider.

@cschow-ucsd cschow-ucsd requested a review from Pumuckl007 March 6, 2021 21:56
Copy link
Member

@Pumuckl007 Pumuckl007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change the tab size to 2 spaces, not four. Other than that it looks really good and I think it should work well.

@Pumuckl007
Copy link
Member

If you are going to reformat all of the code can you make sure to keep the alignment the same. The variable declarations should stack the equals signs. Like this:
image

@cschow-ucsd
Copy link
Contributor Author

Field declarations should be aligned now.
Previously only local variables and assignments were aligned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants