feat: implement pure CRUD operations for table entities by Artuomka · Pull Request #1831 · rocket-admin/rocketadmin

Artuomka · 2026-06-05T14:18:54Z

Add PureCreateRowInTableUseCase for creating rows in tables.
Add PureDeleteRowFromTableUseCase for deleting rows from tables.
Add PureGetRowsFromTableUseCase for retrieving rows from tables.
Add PureReadRowFromTableUseCase for reading a single row by primary key.
Add PureUpdateRowInTableUseCase for updating rows in tables.
Define interfaces for CRUD use cases in table-pure-crud-use-cases.interface.ts.
Implement end-to-end tests for CRUD operations in non-saas-table-pure-crud-operations-e2e.test.ts.

Summary by CodeRabbit

Release Notes

New Features
- Added pure CRUD operations for direct table row management through dedicated API endpoints
- Supports creating, reading, updating, and deleting individual rows
- Includes bulk row retrieval with pagination and filtering capabilities
- All operations include built-in authentication and validation

- Add PureCreateRowInTableUseCase for creating rows in tables. - Add PureDeleteRowFromTableUseCase for deleting rows from tables. - Add PureGetRowsFromTableUseCase for retrieving rows from tables. - Add PureReadRowFromTableUseCase for reading a single row by primary key. - Add PureUpdateRowInTableUseCase for updating rows in tables. - Define interfaces for CRUD use cases in table-pure-crud-use-cases.interface.ts. - Implement end-to-end tests for CRUD operations in non-saas-table-pure-crud-operations-e2e.test.ts.

coderabbitai · 2026-06-05T14:19:11Z

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This pull request introduces a Pure CRUD operations module enabling direct HTTP row-level create, read, update, delete, and list operations against database tables. The implementation includes DTOs, five use cases, a NestJS controller, module wiring, and comprehensive E2E tests covering all endpoints and error conditions.

Changes

Pure CRUD Operations Feature

Layer / File(s)	Summary
Module integration and DI configuration `backend/src/app.module.ts`, `backend/src/common/data-injection.tokens.ts`, `backend/src/entities/table/table-pure-crud-operations/table-pure-crud-operations.module.ts`	Application module imports TablePureCrudOperationsModule; UseCaseType enum gains six new PURE_* identifiers; module registers TypeORM entities, wires use-case providers via DI tokens, and configures AuthWithApiMiddleware for `/table/crud/...` routes.
Request and response data structures `backend/src/entities/table/table-pure-crud-operations/application/data-structures/*`	Five input DTOs (PureCreateRowDs, PureReadRowDs, PureUpdateRowDs, PureDeleteRowDs, PureGetRowsDs) and two output DTOs (PureCrudRowResponseDs, PureFoundRowsResponseDs) define HTTP payload contracts with Swagger/OpenAPI decorators.
Use case interface contracts `backend/src/entities/table/table-pure-crud-operations/use-cases/table-pure-crud-use-cases.interface.ts`	Five exported interfaces standardize the `execute(inputData, inTransaction)` signature for CRUD operations, each returning single-row or multi-row response shapes.
Create and read use cases `backend/src/entities/table/table-pure-crud-operations/use-cases/pure-create-row-in-table.use.case.ts`, `backend/src/entities/table/table-pure-crud-operations/use-cases/pure-read-row-from-table.use.case.ts`	PureCreateRowInTableUseCase validates connection/table/permissions, transforms row data (hashing, UUID/hex conversion), inserts via DAO, and returns created row; PureReadRowFromTableUseCase normalizes primary key, retrieves row, and strips password fields.
Update and delete use cases `backend/src/entities/table/table-pure-crud-operations/use-cases/pure-update-row-in-table.use.case.ts`, `backend/src/entities/table/table-pure-crud-operations/use-cases/pure-delete-row-from-table.use.case.ts`	PureUpdateRowInTableUseCase merges row data, computes prospective primary key, applies transformations, performs update, and returns updated row; PureDeleteRowFromTableUseCase loads row, enforces can_delete permission, performs deletion, and returns deleted row.
Get rows use case `backend/src/entities/table/table-pure-crud-operations/use-cases/pure-get-rows-from-table.use.case.ts`	PureGetRowsFromTableUseCase builds query settings from pagination/search/filter inputs, handles hex-to-binary search conversion, queries DAO with error mapping, post-processes rows with widgets, and returns paginated response.
HTTP controller and routing `backend/src/entities/table/table-pure-crud-operations/table-pure-crud-operations.controller.ts`	TablePureCrudOperationsController exposes POST (create), GET (read), PUT (update), DELETE, and POST /rows (paginated list) endpoints; centralizes primary-key extraction via extractPrimaryKeyFromQuery helper that loads connection, verifies table existence, and assembles key from query fields.
End-to-end test suite `backend/test/ava-tests/non-saas-tests/non-saas-table-pure-crud-operations-e2e.test.ts`	Comprehensive AVA test suite verifies CRUD endpoint status codes and response shapes (only row/rows+pagination, no metadata), validates error handling for missing parameters and non-existent rows, and confirms pagination, search, and filtering behavior.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~75 minutes

Possibly related PRs

rocket-admin/rocketadmin#1746: Modifies the UseCaseType enum in backend/src/common/data-injection.tokens.ts to add/remove table-related use case identifiers.

Suggested reviewers

lyubov-voloshko
gugu

Poem

🐰 A rabbit's ode to CRUD so pure,
Five endpoints now, direct and sure,
Create, read, update, delete with care,
And rows galore—they float through air!
From DTO to DAO's embrace,
Pure operations light the pace! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Security Check	⚠️ Warning	Password leak when addRowInTable returns empty key; incorrect primary key normalization removes 0 and false values; direct database error disclosure in responses.	Fix password leak by always sanitizing before return; Replace falsy checks with explicit null/undefined checks; Wrap DB errors in generic messages.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: implementing pure CRUD operations for table entities, which aligns with the PR's primary objective of adding create, read, update, delete, and get-rows use cases along with their controller and supporting infrastructure.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch backend_new_table_crud_endpoints

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

This PR introduces a new “pure” CRUD surface for table rows (create/read/update/delete + list) intended to return minimal payloads (only row or rows + pagination) and to be usable via API key access. It adds a dedicated Nest module/controller, corresponding use cases + data structures, and an end-to-end test suite for non‑SaaS flows.

Changes:

Added TablePureCrudOperationsModule + TablePureCrudOperationsController with endpoints under /table/crud/*.
Implemented “pure” CRUD use cases and request/response data-structures for row operations.
Added non‑SaaS AVA e2e coverage for create/read/update/delete + list rows (pagination/search/body filters).

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
backend/test/ava-tests/non-saas-tests/non-saas-table-pure-crud-operations-e2e.test.ts	New e2e tests validating pure CRUD endpoints return minimal payload shapes and expected behaviors.
backend/src/entities/table/table-pure-crud-operations/use-cases/table-pure-crud-use-cases.interface.ts	New interfaces defining the pure CRUD use case contracts.
backend/src/entities/table/table-pure-crud-operations/use-cases/pure-create-row-in-table.use.case.ts	Implements create-row use case returning only the created row.
backend/src/entities/table/table-pure-crud-operations/use-cases/pure-read-row-from-table.use.case.ts	Implements read-row-by-PK use case returning only the row.
backend/src/entities/table/table-pure-crud-operations/use-cases/pure-update-row-in-table.use.case.ts	Implements update-row-by-PK use case returning only the updated row.
backend/src/entities/table/table-pure-crud-operations/use-cases/pure-delete-row-from-table.use.case.ts	Implements delete-row-by-PK use case returning the deleted row.
backend/src/entities/table/table-pure-crud-operations/use-cases/pure-get-rows-from-table.use.case.ts	Implements rows listing with pagination/search/query/body-filters returning only rows + pagination.
backend/src/entities/table/table-pure-crud-operations/table-pure-crud-operations.module.ts	Wires up providers, controller, and middleware protection for the new routes.
backend/src/entities/table/table-pure-crud-operations/table-pure-crud-operations.controller.ts	Defines the new HTTP endpoints and request parsing (PK extraction, pagination parsing).
backend/src/entities/table/table-pure-crud-operations/application/data-structures/pure-create-row.ds.ts	New input DS for create row.
backend/src/entities/table/table-pure-crud-operations/application/data-structures/pure-read-row.ds.ts	New input DS for read row.
backend/src/entities/table/table-pure-crud-operations/application/data-structures/pure-update-row.ds.ts	New input DS for update row.
backend/src/entities/table/table-pure-crud-operations/application/data-structures/pure-delete-row.ds.ts	New input DS for delete row.
backend/src/entities/table/table-pure-crud-operations/application/data-structures/pure-get-rows.ds.ts	New input DS for list rows.
backend/src/entities/table/table-pure-crud-operations/application/data-structures/pure-crud-row-response.ds.ts	New minimal response DS for single-row responses.
backend/src/entities/table/table-pure-crud-operations/application/data-structures/pure-found-rows-response.ds.ts	New minimal response DS for list responses.
backend/src/common/data-injection.tokens.ts	Adds DI tokens for the new pure CRUD use cases.
backend/src/app.module.ts	Registers the new pure CRUD module in the main application module.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+		let parsedPage = 0;
+		let parsedPerPage = 0;
+		if (page && perPage) {
+			parsedPage = parseInt(page, 10);
+			parsedPerPage = parseInt(perPage, 10);
+			if ((parsedPage && parsedPage <= 0) || (parsedPerPage && parsedPerPage <= 0)) {
+				throw new HttpException({ message: Messages.PAGE_AND_PERPAGE_INVALID }, HttpStatus.BAD_REQUEST);
+			}
+		}


+		const primaryColumns = await dao.getTablePrimaryColumns(tableName, userEmail);
+		const primaryKey: Record<string, unknown> = {};
+		for (const primaryColumn of primaryColumns) {
+			if (isObjectPropertyExists(primaryColumn, 'column_name')) {
+				primaryKey[primaryColumn.column_name] = query[primaryColumn.column_name];
+			}
+		}
+		return primaryKey;


+			const addedRowPrimaryKey = (await dao.addRowInTable(tableName, row, userEmail)) as Record<string, unknown>;
+			if (!addedRowPrimaryKey || isObjectEmpty(addedRowPrimaryKey)) {
+				return { row };
+			}


Copilot AI review requested due to automatic review settings June 5, 2026 14:18

Artuomka enabled auto-merge June 5, 2026 14:19

Copilot started reviewing on behalf of Artuomka June 5, 2026 14:19 View session

coderabbitai Bot requested review from gugu and lyubov-voloshko June 5, 2026 14:19

Artuomka merged commit 869e97a into main Jun 5, 2026
16 of 18 checks passed

Artuomka deleted the backend_new_table_crud_endpoints branch June 5, 2026 14:27

Copilot AI reviewed Jun 5, 2026

View reviewed changes

This was referenced Jun 12, 2026

feat(agents-microservice): migrate AI request endpoints to agents microservice #1841

Merged

feat: implement column-level read permissions for table queries #1843

Merged

feat: implement public access permissions for unauthenticated users #1844

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: implement pure CRUD operations for table entities#1831

feat: implement pure CRUD operations for table entities#1831
Artuomka merged 1 commit into
mainfrom
backend_new_table_crud_endpoints

Artuomka commented Jun 5, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 5, 2026 •

edited

Loading

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

❌ Failed checks (2 warnings)

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Artuomka commented Jun 5, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Release Notes

Uh oh!

coderabbitai Bot commented Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

❌ Failed checks (2 warnings)

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Artuomka commented Jun 5, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 5, 2026 •

edited

Loading