Skip to content

add/edit record: add checking that primary key with column_default is non modifing key #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lyubov-voloshko merged 1 commit into from
Jul 28, 2025
Merged

add/edit record: add checking that primary key with column_default is non modifing key #1269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/app/components/db-table-row-edit/db-table-row-edit.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ <h3>
Back
</a>
<button type="button" mat-button color="primary"
*ngIf="(keyAttributesFromStructure.length || hasKeyAttributesFromURL) && permissions.edit"
*ngIf="(keyAttributesListFromStructure.length || hasKeyAttributesFromURL) && permissions.edit"
class="actions__continue"
data-testid="record-save-and-continue-editing-button"
[disabled]="submitting || editRowForm.form.invalid"
Expand Down
15 changes: 11 additions & 4 deletions frontend/src/app/components/db-table-row-edit/db-table-row-edit.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export class DbTableRowEditComponent implements OnInit {
public keyAttributesFromURL: object = {};
public hasKeyAttributesFromURL: boolean;
public dubURLParams: object;
public keyAttributesFromStructure: [] = [];
public keyAttributesListFromStructure: string[] = [];
public isPrimaryKeyUpdated: boolean;
public tableTypes: object;
public tableWidgets: object;
Expand Down Expand Up @@ -174,7 +174,7 @@ export class DbTableRowEditComponent implements OnInit {
edit: true
};

this.keyAttributesFromStructure = res.primaryColumns;
this.keyAttributesListFromStructure = res.primaryColumns.map((field: TableField) => field.column_name);
this.readonlyFields = res.readonly_fields;
this.tableForeignKeys = res.foreignKeys;
this.setRowStructure(res.structure);
Expand Down Expand Up @@ -214,8 +214,11 @@ export class DbTableRowEditComponent implements OnInit {
this.dispalyTableName = res.display_name || normalizeTableName(this.tableName);
this.title.setTitle(`${this.dispalyTableName} - Edit record | Rocketadmin`);
this.permissions = res.table_access_level;
this.keyAttributesListFromStructure = res.primaryColumns.map((field: TableField) => field.column_name);

this.nonModifyingFields = res.structure.filter((field: TableField) => !this.getModifyingFields(res.structure).some(modifyingField => field.column_name === modifyingField.column_name)).map((field: TableField) => field.column_name);
this.nonModifyingFields = res.structure
.filter((field: TableField) => !this.getModifyingFields(res.structure).some(modifyingField => field.column_name === modifyingField.column_name))
.map((field: TableField) => field.column_name);
this.readonlyFields = [...res.readonly_fields, ...this.nonModifyingFields];
if (this.connectionType === DBtype.Dynamo) {
this.readonlyFields = [...this.readonlyFields, ...res.primaryColumns.map((field: TableField) => field.column_name)];
Expand Down Expand Up @@ -521,7 +524,11 @@ export class DbTableRowEditComponent implements OnInit {
}

getModifyingFields(fields) {
return fields.filter((field: TableField) => !field.auto_increment && !(timestampTypes.includes(field.data_type) && field.column_default && defaultTimestampValues[this.connectionType].includes(field.column_default.toLowerCase().replace(/\(.*\)/, ""))));
return fields.filter((field: TableField) =>
!field.auto_increment &&
!(this.keyAttributesListFromStructure.includes(field.column_name) && field.column_default) &&
!(timestampTypes.includes(field.data_type) && field.column_default && defaultTimestampValues[this.connectionType].includes(field.column_default.toLowerCase().replace(/\(.*\)/, "")))
);
}

updateField = (updatedValue: any, field: string) => {
Expand Down