Skip to content

Add data-testid attributes to permission dialog elements for test automation #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lyubov-voloshko merged 4 commits into from
Jul 9, 2025
Merged

Add data-testid attributes to permission dialog elements for test automation #1241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
846fbdb
Initial plan
Copilot Jul 3, 2025
2d053ba
Add data-testid attributes to permission dialog elements for test aut…
Copilot Jul 3, 2025
29cbbe8
Merge branch 'main' into copilot/fix-1239
gugu Jul 3, 2025
93999bf
Merge branch 'main' into copilot/fix-1239
lyubov-voloshko Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/app/components/users/group-add-dialog/group-add-dialog.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ <h1 mat-dialog-title>Create group of users</h1>
<mat-dialog-content>
<mat-form-field appearance="outline">
<mat-label>Enter group title</mat-label>
<input matInput [(ngModel)]="groupTitle" name="title" #title="ngModel" required>
<input matInput [(ngModel)]="groupTitle" name="title" #title="ngModel" required data-testid="group-title-input">
<mat-error *ngIf="title.errors?.required && (title.invalid && title.touched)">Title should not be empty.</mat-error>
</mat-form-field>
</mat-dialog-content>
Expand Down
7 changes: 4 additions & 3 deletions ...end/src/app/components/users/permissions-add-dialog/permissions-add-dialog.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ <h2 class="mat-subtitle-1 permissions__title">Tables</h2>
<span *ngIf="connectionAccess === 'edit' || group.title === 'Admin'">Full access</span>
<div class="tables-options">
<button mat-button type="button" *ngIf="!(connectionAccess === 'edit' || group.title === 'Admin')"
(click)="grantFullTableAccess()">
(click)="grantFullTableAccess()" data-testid="full-access-button">
Full access
</button>

Expand All @@ -52,7 +52,7 @@ <h2 class="mat-subtitle-1 permissions__title">Tables</h2>
<div>Edit</div>
</div>

<div *ngFor="let table of tablesAccess; let i = index" class="tables-list__item">
<div *ngFor="let table of tablesAccess; let i = index" class="tables-list__item" [attr.data-testid]="'table-row-' + table.tableName">
<div style="display: contents;">
<div class="tableVisibility">
<input type="checkbox" name="{{table.tableName}}-visibility" id="{{table.tableName}}-visibility"
Expand All @@ -76,7 +76,8 @@ <h2 class="mat-subtitle-1 permissions__title">Tables</h2>
[disabled]="!table.accessLevel.visibility"
(change)="uncheckActions(table)"
[(ngModel)]="table.accessLevel.readonly"
(click)="onVisibilityChange($event, i)">
(click)="onVisibilityChange($event, i)"
[attr.data-testid]="table.tableName + '-readonly-toggle'">
</mat-slide-toggle>
<div (click)="onRecordActionPermissionChange('add', i)">
<mat-checkbox name="{{table.tableName}}-add"
Expand Down