Skip to content

disable widget type validation #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Artuomka merged 1 commit into from
Jul 3, 2025
Merged

disable widget type validation #1240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions backend/src/entities/widget/utils/validate-create-widgets-ds.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@ export async function validateCreateWidgetsDs(
}
}
const { widget_type } = widgetDS;
if (widget_type) {
if (!Object.keys(WidgetTypeEnum).find((key) => key === widget_type)) {
errors.push(Messages.WIDGET_TYPE_INCORRECT);
}
}
// if (widget_type) {
// if (!Object.keys(WidgetTypeEnum).find((key) => key === widget_type)) {
// errors.push(Messages.WIDGET_TYPE_INCORRECT);
// }
// }
if (widget_type && widget_type === WidgetTypeEnum.Password) {
if (
widgetDS.widget_params['algorithm'] &&
Expand Down
2 changes: 1 addition & 1 deletion backend/test/ava-tests/non-saas-tests/non-saas-table-widgets-e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@ test.serial(`${currentTest} should return table widgets without deleted widget`,
t.is(getTableWidgetsRO.length, 1);
});

test.serial(
test.skip(
`${currentTest} should throw exception when table widget with incorrect type passed in request`,
async (t) => {
const { token } = await registerUserAndReturnUserInfo(app);
Expand Down
2 changes: 1 addition & 1 deletion backend/test/ava-tests/saas-tests/table-widgets-e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ test.serial(`${currentTest} should return table widgets without deleted widget`,
t.is(getTableWidgetsRO.length, 1);
});

test.serial(
test.skip(
`${currentTest} should throw exception when table widget with incorrect type passed in request`,
async (t) => {
const { token } = await registerUserAndReturnUserInfo(app);
Expand Down
Loading