Add data-testid attributes for test automation#1231
Closed
Copilot wants to merge 5 commits into
Closed
Conversation
Co-authored-by: gugu <75169+gugu@users.noreply.github.com>
Co-authored-by: gugu <75169+gugu@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add data-testid attributes
Add data-testid attributes for test automation
Jun 30, 2025
Contributor
|
@copilot remove package.lock, we use yarn |
Co-authored-by: gugu <75169+gugu@users.noreply.github.com>
Contributor
Author
Contributor
|
@copilot rollback all changes to yarn.lock as well |
Co-authored-by: gugu <75169+gugu@users.noreply.github.com>
Contributor
Author
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the request to add data-testid attributes to specific UI elements to improve test automation capabilities.
Changes Made
Verified Existing Implementation:
data-testid="company-name"already exists inconnections-list.component.htmldata-testid="table-paginator"already exists indb-table.component.htmlAdditional Enhancement:
data-testid="audit-paginator"to the audit component's paginator for consistency across similar componentsFindings
The main testids requested in the issue were already properly implemented in the codebase:
Company name display: Located in
/frontend/src/app/components/connections-list/connections-list.component.htmlline 5Table pagination: Located in
/frontend/src/app/components/dashboard/db-table/db-table.component.htmlline 380The requested data-testid attributes were already in place, suggesting this issue may have been resolved in a previous commit. I've added an additional testid for the audit paginator to maintain consistency across similar UI components.
Testing
Fixes #1143.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
googlechromelabs.github.ionode install.mjs(dns block)https://storage.googleapis.com/chrome-for-testing-public/131.0.6778.204/linux64/chrome-headless-shell-linux64.zipnode install.mjs(http block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.