Skip to content

fix table search and minor mistypos #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lyubov-voloshko merged 1 commit into from
Jun 11, 2025
Merged

fix table search and minor mistypos #1210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/src/app/components/dashboard/db-tables-list/db-tables-list.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ <h1 class="mat-h2 connection-title">{{connectionTitle}}</h1>
<mat-form-field *ngIf="!collapsed" appearance="fill" class="search-input">
<input matInput name="search" #search="ngModel"
placeholder="Search"
[(ngModel)]="searchString"
(keyup)="serach()">
[(ngModel)]="substringToSearch"
(keyup)="searchSubstring()">
<mat-error *ngIf="foundTables.length === 0">Nothing found.</mat-error>
</mat-form-field>
<mat-nav-list data-testid="tables-list">
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/app/components/dashboard/db-tables-list/db-tables-list.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export class DbTablesListComponent {
@Input() selectedTable: string;
@Input() collapsed: boolean;

public searchString: string;
public substringToSearch: string;
public foundTables: TableProperties[];
constructor(
private _tableState: TableStateService,
Expand All @@ -45,9 +45,9 @@ export class DbTablesListComponent {
this.foundTables = this.tables;
}

serach() {
searchSubstring() {
this.foundTables = this.tables
.filter(tableItem => tableItem.table.toLowerCase().includes(this.searchString.toLowerCase()) || (tableItem.display_name && tableItem.display_name.toLowerCase().includes(this.searchString.toLowerCase())));
.filter(tableItem => tableItem.table.toLowerCase().includes(this.substringToSearch?.toLowerCase()) || (tableItem.display_name && tableItem.display_name.toLowerCase().includes(this.substringToSearch.toLowerCase())));
}

getTableName(table: TableProperties) {
Expand Down