Add ability to authenticate with Amster credentials#526
Add ability to authenticate with Amster credentials#526vscheuber merged 2 commits intorockcarver:mainfrom
Conversation
|
@phalestrivir I believe there are pre-requisites for your new classic tests in AuthenticateOps.test.js that are not available in the rockcarver org and frodo-lib repo. So the tests passed before I merged the PR but the tests failed after merging: The tests that run before merge run in the source repo, while of course after the merge they run in the rockcarver/frodo-lib repo. Could you maybe look into that and send me instructions on what to setup so the tests pass? |
|
@vscheuber I looked at the error when I try to run it locally, the error I got was on a line that was running Would you like me to create another PR with those package-lock.json changes or do you want to do that? Edit: Nevermind, I double checked and the package-lock does not get updated from doing Edit 2: I noticed the actions are already using |
|
@phalestrivir it's really odd: the tests pass for me on MacOS running node 24, which is the nodes version failing on GitHub. Granted, we don't know if other node versions would fail, too, because I configured it to fail fast. But I am really flabbergasted by this. |
|
@vscheuber I tried a few different things, such as running the tests in different linux VM's that I have (just to make sure the environment wasn't affecting it) and also creating/merging a PR in our TriVir repo to see if the GitHub actions would fail there, but so far I haven't been able to reproduce the errors. I've already talked with @hfranklin about it and he's looking into it as well, so hopefully we'll be able to find out what's causing it here sometime soon. |
This PR adds the ability to authenticate to an AM classic deployment using Amster credentials (i.e. a public/private key pair). The private key can be in a variety of formats such as PKCS, JWK, and OpenSSH, but is ultimately stored in PKCS#8 format. You can also use encrypted private keys by providing the passphrase when creating the connection profile.
I also refactored AuthenticateOps a bit since some of the code for doing authentication is re-used since it involves getting and writing callbacks in a journey similar to how the authentication is done with username/password in AIC deployments.
Another PR in the CLI makes the corresponding changes there to the
frodo conn add/savecommand.