[EXPERIMENTAL] Allow to render translations fields separately#62
Draft
[EXPERIMENTAL] Allow to render translations fields separately#62
Conversation
d617566 to
c36a82b
Compare
c36a82b to
be8b13d
Compare
Sometimes we want to render the translations fields separated from each other,
with not translatable fields or any other HTML component in between.
Unfortunately, this was not possible because the hidden fields `:_destroy` and
`:locale` were rendered for each `translatable_field` call resulting in
duplicated fields for each translation and invalid HTML. So now we ensure to
render each translation hidden_fields once per form.
In addition, the form fields for the same translation had a different index
when using more than one `translatable_fields` block. So now, the index we use
for translation fields is the position the translation locale occupies in the
application's array of available languages.
This is an example of what we want to wirte
```
<%= f.translatable_fields do |translations_form| %>
<%= translations_form.text_field :title %>
<% end %>
Some HTML here
<%= f.translatable_fields do |translations_form| %>
<%= translations_form.text_area :description %>
<% end %>
```
The output for the same translation fields was:
```
debate[translations_attributes][1][_destroy]
debate[translations_attributes][1][locale]
debate[translations_attributes][1][title]
Some HTML here
debate[translations_attributes][33][_destroy]
debate[translations_attributes][33][locale]
debate[translations_attributes][33][description]
```
After this patch, translation hidden fields are not duplicated and the index is
the same for the same translation fields:
```
debate[translations_attributes][1][_destroy]
debate[translations_attributes][1][locale]
debate[translations_attributes][1][title]
Some HTML here
debate[translations_attributes][1][description]
```
be8b13d to
3cdac2f
Compare
25ba35f to
df9b00f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes we want to render the translations fields separated from each other, with not translatable fields or any other HTML component in between. Unfortunately, this was not possible because the hidden fields
:_destroyand:localewere rendered for eachtranslatable_fieldcall resulting in duplicated fields for each translation and invalid HTML. So now we ensure to render each translation hidden_fields once per form.In addition, the form fields for the same translation had a different index when using more than one
translatable_fieldsblock. So now, the index we use for translation fields is the position the translation locale occupies in the application's array of available languages.This is an example of what we want to do:
The output for the previous code before this patch was:
Now, translation hidden fields are not duplicated and the index is the same for the same translation fields: