-
Notifications
You must be signed in to change notification settings - Fork 19
React starter with routing, params, query, mutations. #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Oh looks like we both created a React-Apollo starter in parallel! I'll take a look tonight and see if we can just merge them together :] |
|
@stubailo Sounds good 👍 |
| @@ -0,0 +1,201 @@ | |||
| Apache License | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't an MIT license be better? This means any project started from this kit would be burdened with a more restrictive license.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, or maybe remove entirely? Just got created from create-react-app....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wow, that's really surprising that CRA adds the Apache license. I do think having a permissive license is important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad... CRA does not add a license; that came from GH on new repo
|
I think this example is a bit more in-depth than mine btw, the easiest thing might be to have both. |
|
Your code is more elegant (functional components; recompose is interesting). This one has an example mutation... |
No description provided.