Open
Conversation
grosser
commented
Apr 13, 2025
|
|
||
| for _, nm := range sortedNodeMetrics { | ||
| cp.printNodeLine(nm.name, nm) | ||
| for _, nm := range nms { |
Contributor
Author
There was a problem hiding this comment.
renamed so variables are consistent across all the printer methods
Contributor
Author
robscott
reviewed
Aug 18, 2025
| cp.file = os.Stdout | ||
|
|
||
| sortedNodeMetrics := cp.cm.getSortedNodeMetrics(cp.opts.SortBy) | ||
| nms := cp.cm.getSortedNodeMetrics(cp.opts.SortBy) |
Owner
There was a problem hiding this comment.
While I like the overall idea of shorter variable names, I think these may be too short. I'd prefer nodeMetrics, podMetrics, and containerMetrics, particularly as cms and pms all feel like they could be acronnyms for any number of things.
Contributor
Author
|
rebased + renamed, please take another look @robscott |
Contributor
Author
1 similar comment
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when trying to add node age I noticed that printing extra node columns was hard,
also that the printers could use some docs + consistency
cc @robscott