Add auto_close_passing_reviews config option#595
Merged
wesm merged 3 commits intoroborev-dev:mainfrom Mar 30, 2026
Merged
Conversation
Automatically mark reviews as closed when they pass with no findings. Configurable globally in ~/.roborev/config.toml and per-repo in .roborev.toml (per-repo overrides global). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Use IsReviewJob() instead of !IsFixJob() so auto-close only fires for actual review jobs (review, range, dirty), not task/insights/compact. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Verify that task jobs with a passing verdict are not auto-closed even when auto_close_passing_reviews is enabled. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
roborev: Combined Review (
|
mariusvniekerk
approved these changes
Mar 30, 2026
Contributor
Author
|
Looks like I introduced a race, per https://github.com/roborev-dev/roborev/actions/runs/23765857336/job/69245061077?pr=598. Fixing… |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auto_close_passing_reviewsconfig option (global and per-repo) that automatically marks reviews as closed when they pass with no findings.roborev.tomloverrides global~/.roborev/config.tomlusing the standardresolveBoolchainIsReviewJob()so it only fires for review/range/dirty jobs, not task/insights/compact/fix🤖 Generated with Claude Code