Default to $XDG_RUNTIME_DIR for the daemon socket path when set#594
Open
atheriel wants to merge 1 commit intoroborev-dev:mainfrom
Open
Default to $XDG_RUNTIME_DIR for the daemon socket path when set#594atheriel wants to merge 1 commit intoroborev-dev:mainfrom
atheriel wants to merge 1 commit intoroborev-dev:mainfrom
Conversation
Putting the daemon's socket into `$XDG_RUNTIME_DIR` on Linux has a nicer security story that writing into `/tmp`, since (a) it's a tmpfs, while `/tmp` is often a regular directory; and (b) permissions are handled on the parent directory by systemd already. This is technically a very minor breaking change, but I doubt anyone is relying on the default socket path being in `/tmp/roborev-<UID>` yet. Closes roborev-dev#580. Signed-off-by: Aaron Jacobs <atheriel@gmail.com>
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Putting the daemon's socket into
$XDG_RUNTIME_DIRon Linux has a nicer security story that writing into/tmp, since (a) it's a tmpfs, while/tmpis often a regular directory; and (b) permissions are handled on the parent directory by systemd already.This is technically a very minor breaking change, but I doubt anyone is relying on the default socket path being in
/tmp/roborev-<UID>yet.Closes #580.