Skip to content

Fix undo for completed polygons#28

Open
pankajarm wants to merge 1 commit into
roboflow:mainfrom
pankajarm:fix-undo-completed-polygons
Open

Fix undo for completed polygons#28
pankajarm wants to merge 1 commit into
roboflow:mainfrom
pankajarm:fix-undo-completed-polygons

Conversation

@pankajarm
Copy link
Copy Markdown

Summary

  • fix Undo so it removes the last completed polygon when there are no in-progress points
  • clear JSON output when all points are removed
  • update Clear All to target the existing coordinate output elements

Fixes #23.

Testing

  • node --check script.js

@pankajarm
Copy link
Copy Markdown
Author

Quick note on the failing check: this appears unrelated to the script.js changes in this PR.

The failed job is the repository's Welcome WorkFlow (actions/first-interaction@v1.1.1) on pull_request_target. The job log shows the workflow token only has read permissions and fails with:

Resource not accessible by integration

Local validation for this PR still passes:

node --check script.js

If helpful, the welcome workflow likely needs explicit write permissions in the base repo workflow, e.g. issues: write / pull-requests: write, or the failed welcome-bot check can be ignored for this PR since the Socket checks passed and no dependency files changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

function undo() not work!!

1 participant