Added 2 new Arguments: '--skip-printout' & '--collection'#12
Open
Whatchawnt wants to merge 18 commits intorobobeaver6:masterfrom
Open
Added 2 new Arguments: '--skip-printout' & '--collection'#12Whatchawnt wants to merge 18 commits intorobobeaver6:masterfrom
Whatchawnt wants to merge 18 commits intorobobeaver6:masterfrom
Conversation
1. Fixed a bug that resulted in a NameError when the provided users are invalid. 2. Added Resource argument as a requirement for server connection method (due to the switching of users). 3. Added a check for when all users entered are invalid home users. 4. Minor changes to comments.
1. Added "--resource" argument to requests via server connection method (now a required argument). 2. Added Some examples of using "https" with server connection method.
Minor spelling fix
Minor change, changed line 1281 to remove str conversion.
From: logger.debug(f'\nHome User [matched]: {str(homeUser)}\n')
To: logger.debug(f'\nHome User [matched]: {homeUser}\n')
Cleanup commented out code.
Display "Error - No Valid Home Users Submitted." Error only when the homeusers argument is passed into the script.
Fixed a bug where some movies would be prevented from being added to a playlist due to an already added item being attemptedly added multiple times; however, since it is already in the playlist it was not added again but still caused the playlist count to be lower than expected at times due to this.
Added a check to make sure a user entered either a --adminuser argument or a --homeusers argument.
Added the ability to purge a playlist without needing to provide the --select-library, --allshows, or --allmovies arguments.
1. Added a check to no longer allow the use of the "--purge" argument alongside the following arguments: "--select-library", "--allshows", or "--allmovies" 2. Minor changes to comments.
Forgot additional parenthesis around if statement
updated references of "--admin" to "--adminuser" in examples.
1. Fixed argument references. 2. Updated examples and comments.
Added comma after "--exclude-library"
1 - Added the ability to skip the printout of the playlist to the console with the '--skip-printout' option. 2 - Added an option '--collection' which takes an argument of a Collection Name, in order to only grab items from the specified collection by name in order to add them to the playlist generation. The collection name provided will be used to query through each associated library, filtering and grabbing items who are part of a collection with the same name to add them to the playlist.
1 - Added the help details and a usage example for '--skip-printout' argument. 2 - Added the help details and a usage example for '--collection' argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Script - Changes]
1 - Added the ability to skip the printout of the playlist to the console with the '--skip-printout' option.
2 - Added an option '--collection' which takes an argument of a Collection Name, in order to only grab items from the specified collection by name in order to add them to the playlist generation. The collection name provided will be used to query through each associated library, filtering and grabbing items who are part of a collection with the same name to add them to the playlist.
[ReadMe - Changes]
1 - Added the help details and a usage example for '--skip-printout' argument.
2 - Added the help details and a usage example for '--collection' argument.