Add deterministic practiceLog pruning for Bengali progress storage#53
Open
robirahman wants to merge 1 commit intomainfrom
Open
Add deterministic practiceLog pruning for Bengali progress storage#53robirahman wants to merge 1 commit intomainfrom
robirahman wants to merge 1 commit intomainfrom
Conversation
Contributor
|
Failed prettier code check. Check this file for more information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
progress.practiceLogby keeping the stored daily XP history bounded and deterministic.YYYY-MM-DDdates and remove invalid or stale entries so progress storage is predictable and safe to persist.Description
prunePracticeLog(log, maxDays = 365)which enforcesYYYY-MM-DDkeys, validates calendar dates, computes a UTC-based cutoff window, sorts keys deterministically, and returns a pruned object containing only recent entries._loadProgressLSand mark the loaded data as mutated so migrated/pruned logs are persisted back with_saveProgressLS._saveProgressLSso writes remain bounded over time.Testing
node --check bengali/app.jswhich completed successfully indicating the updated file parses without syntax errors.Codex Task