making some changes#3
Open
Mannxxx wants to merge 5 commits intorobinroy03:mainfrom
Open
Conversation
AbhijithGanesh
suggested changes
Oct 4, 2023
There was a problem hiding this comment.
Please compare this against the current main.py file. Creating a new file isn't useful
Author
|
Yeah, I've updated the main file. |
robinroy03
reviewed
Oct 5, 2023
| else: | ||
| output = dict_to_mermaid(output) | ||
| store_to_gsheet(content, user_prompt=user_prompt, error=False, **st.secrets.gspread_credentials) | ||
| store_to_gsheet(content, user_prompt = user_prompt, error = True, **st.secrets.gspread_credentials) # passing google sheet credentials |
Owner
There was a problem hiding this comment.
What is the reasoning behind changing the boolean in function?
Author
There was a problem hiding this comment.
I was just checking for errors, but there's no actual necessity to set it to 'true.' As long as the application runs successfully, there's no need to worry about it. Although, I should probably change it back to 'false,' I guess.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<pre class="mermaid">element to control its appearance. This obviously can be further customized and styled as needed.I think by making these changes, the Mermaid diagram should run more seamlessly within your Streamlit application, and the issue of the unexpected rectangle should be addressed.
Could you please check it once?