Conversation
|
Looked a bit at the typechecking error and I couldn't see how it should relate with my change, could anyone help me take a quick look ? |
|
I tried running master through travis and got the same error. The job succeeded on exactly the same source code 11 days ago, so indeed it seems unrelated. One difference I can see in the output from the travis runs is that the mypy version install differs:
I can repeat the problem locally by running So I'm guessing the newer tox version either found a bug, or we need to tell mypy to ignore the typing error because it's intentional. |
|
Opened #672 for this. |
|
Nice debugging, thanks for the support @forsberg |
|
|
I am updating venusian as at the current version it always displays this deprecation warning:
but I checked and from version 2.0.0 onwards they fixed this (see https://github.com/Pylons/venusian/blob/24d1d2515972dd61ba1881fec780d658c254a612/CHANGES.rst).
I'm not familiar with the codebase so there of course could be some breakage with updating the library but in case there's not it would be great to be able to remove that deprecation warning from faust