Skip to content

adding max time option #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eastandwestwind wants to merge 3 commits into
base: master
Choose a base branch
from
Open

adding max time option #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9c46c7
adding max time option
eastandwestwind Jul 11, 2016
225573e
default max time 1e3
eastandwestwind Jul 11, 2016
6400720
1e10 max
eastandwestwind Jul 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added .DS_Store
View file
Open in desktop
Binary file not shown.
4 changes: 3 additions & 1 deletion riveted.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ var riveted = (function() {
sendUserTiming,
reportInterval,
idleTimeout,
maxTime,
nonInteraction,
universalGA,
classicGA,
Expand All @@ -48,6 +49,7 @@ var riveted = (function() {
options = options || {};
reportInterval = parseInt(options.reportInterval, 10) || 5;
idleTimeout = parseInt(options.idleTimeout, 10) || 30;
maxTime = parseInt(options.maxTime, 10) || 1e10;
gaGlobal = options.gaGlobal || 'ga';

/*
Expand Down Expand Up @@ -211,7 +213,7 @@ var riveted = (function() {

function clock() {
clockTime += 1;
if (clockTime > 0 && (clockTime % reportInterval === 0)) {
if (clockTime > 0 && clockTime < maxTime && (clockTime % reportInterval === 0)) {
sendEvent(clockTime);
}

Expand Down
5 changes: 3 additions & 2 deletions test/test.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,11 @@
riveted.init({
reportInterval: 2,
idleTimeout: 5,
maxTime: 1e3,
nonInteraction: false,
//gaGlobal: '__gaTracker',
gaTracker: 'fooo'

/*eventHandler: function(event) {
console.log(event);
},
Expand All @@ -50,4 +51,4 @@
<body>
<h1>Test</h1>
</body>
</html>
</html>