Allow overrides of helm chart values and resource definitions#39
Open
abierbaum wants to merge 4 commits intorobertd:mainfrom
Open
Allow overrides of helm chart values and resource definitions#39abierbaum wants to merge 4 commits intorobertd:mainfrom
abierbaum wants to merge 4 commits intorobertd:mainfrom
Conversation
Owner
|
@abierbaum I just bumped karpenter to v0.26.1. If you could rebase your PR that'd help me review it faster. Thanks. |
Author
|
@robertd I am looking back at this again. What do you think about the concept in general, specifically the finalizeProvisioner callback to allow users to override custom items? |
Owner
|
I have to come back to this at some point... life's been busy lately. :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rough PR for allowing overrides with the Karpenter CDK construct. I needed this so I can manually adjust the values sent to Helm and add more settings to the Karpenter resources.
I am looking for feedback on this PR.
Notes:
I did this because lodash was already being pulled in for some of the internal dependencies and I thought that may be a good way to get it in. I am open to any other options you may want on this depdendency.
I tried to use
yarn linkbut something about the construct and cdk dependencies is preventing my CDK application from running against this package. If you have any recommendations for the best development practices to use here, I am open to any ideas.