Chore: Move dev-dependencies to [tool.poetry.group.dev] (Poetry deprecation fix)#1871
Chore: Move dev-dependencies to [tool.poetry.group.dev] (Poetry deprecation fix)#1871lb803 wants to merge 2 commits intorobbrad:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe pull request updates Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
pyproject.toml (1)
44-46: Consider reordering sections for conventional TOML structure.The group declaration
[tool.poetry.group.dev]appears after its dependencies subtable[tool.poetry.group.dev.dependencies]. While functionally equivalent, placing the parent section first is more conventional and improves readability:[tool.poetry.group.dev] optional = false [tool.poetry.group.dev.dependencies] black = "*" ...Also note that
optional = falseis the default for Poetry dependency groups, so this line is technically redundant—though being explicit is fine.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pyproject.toml` around lines 44 - 46, Move the parent TOML section [tool.poetry.group.dev] to appear before its subtable [tool.poetry.group.dev.dependencies] so the file reads with the parent section first (e.g., place [tool.poetry.group.dev] with its optional = false setting immediately above [tool.poetry.group.dev.dependencies]); optionally remove the redundant optional = false line since Poetry defaults to false if you prefer brevity.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@pyproject.toml`:
- Around line 44-46: Move the parent TOML section [tool.poetry.group.dev] to
appear before its subtable [tool.poetry.group.dev.dependencies] so the file
reads with the parent section first (e.g., place [tool.poetry.group.dev] with
its optional = false setting immediately above
[tool.poetry.group.dev.dependencies]); optionally remove the redundant optional
= false line since Poetry defaults to false if you prefer brevity.
ℹ️ Review info
Configuration used: defaults
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
poetry.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
pyproject.toml
[tool.poetry.group.dev] as coderabbitai suggested to be redundant in this case
Hi everyone,
Description of the Issue
I noticed that I was getting a warning while installing the poetry dependencies:
I did a quick search and I realised that
tool.poetry.dev-dependenciesis deprecated in favor oftool.poetry.group.dev.dependenciesin poetry 2.0.0.Refs:
https://python-poetry.org/blog/announcing-poetry-2.0.0/
python-poetry/poetry-core#754
Description of the PR
This PR replaces
tool.poetry.dev-dependencieswithtool.poetry.group.dev.dependenciesin the pyproject.toml file.Summary by CodeRabbit