Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
=======================================
Coverage 89.71% 89.71%
=======================================
Files 19 19
Lines 1954 1954
=======================================
Hits 1753 1753
Misses 201 201 Continue to review full report at Codecov.
|
robashaw
pushed a commit
that referenced
this pull request
Sep 13, 2021
…to have changed, due to reformatting
Draft
Owner
|
I'm closing this PR because I've taken what you've done here and put it in the upcoming update, see PR #51 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the start to #28
The next step would be to pick a format specification, you like. This format is specified in the .clang-format file.
This can help to determine what you like. https://zed0.co.uk/clang-format-configurator/
Afterwards the whole codebase can be reformatted using a simple
make format.In a last step the CI could check the formatting and reject PRs, which are not properly formatted.
@junghans can probably comment on that.