Skip to content

added clang-format structure#30

Closed
JensWehner wants to merge 1 commit intorobashaw:masterfrom
JensWehner:clang_format
Closed

added clang-format structure#30
JensWehner wants to merge 1 commit intorobashaw:masterfrom
JensWehner:clang_format

Conversation

@JensWehner
Copy link
Contributor

This is the start to #28

The next step would be to pick a format specification, you like. This format is specified in the .clang-format file.

This can help to determine what you like. https://zed0.co.uk/clang-format-configurator/

Afterwards the whole codebase can be reformatted using a simple make format.

In a last step the CI could check the formatting and reject PRs, which are not properly formatted.
@junghans can probably comment on that.

@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #30 (ee988e0) into master (e6aa13d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #30   +/-   ##
=======================================
  Coverage   89.71%   89.71%           
=======================================
  Files          19       19           
  Lines        1954     1954           
=======================================
  Hits         1753     1753           
  Misses        201      201           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6aa13d...ee988e0. Read the comment docs.

@robashaw robashaw added this to the 1.1 milestone Feb 6, 2021
robashaw pushed a commit that referenced this pull request Sep 13, 2021
@robashaw robashaw mentioned this pull request Sep 13, 2021
@robashaw
Copy link
Owner

I'm closing this PR because I've taken what you've done here and put it in the upcoming update, see PR #51
Thanks for introducing me to this!

@robashaw robashaw closed this Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants