Feature: starting/ stopping a recording will also start/ stop playback#524
Closed
sriseley wants to merge 0 commit intorncbc:mainfrom
Closed
Feature: starting/ stopping a recording will also start/ stop playback#524sriseley wants to merge 0 commit intorncbc:mainfrom
sriseley wants to merge 0 commit intorncbc:mainfrom
Conversation
Owner
mainly historic: it follows the old tape-recorder action model of yore which is/was set right from the beginning two decades ago :) really appreciate the effort in taking to explain so simple feature change, however, to be just perfect it should be taken as an user option or preference; old and most current users are or seem to be comfortable with the record button action model, so seeing to change so abruptly might raise some eyebrows to say the least. |
Author
|
Hi @rncbc thanks very much for the info, I've marked as draft and I'll refactor into a user configurable option 😊 |
2d4fa64 to
aa7f5b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The first time I used Qtractor 1.2.0 (installed from dnf), I was clicking the record button with a track armed, and from my perspective nothing was happening, I was confused and unsure if Qtractor was working correctly. I realised that starting a recording actually required two steps: 1. clicking record and 2. clicking play. This did not meet my expectations as a user accustomed to audio recording software eg Audacity.
I have decided to implement the feature and raise a PR to invite discussion. I am curious to understand if there are historic or Qtractor-specific reasons why starting a recording requires two clicks as opposed to one.
Feature description
This pull request starts playback as well as recording when the record button is pressed.
Implementation details
Development environment
Developed and built on Fedora Linux 42 using the following build parameters:
cmake -B build -DCONFIG_VST3=OFF -DCONFIG_VST3SDK=OFF -DCONFIG_CLAP=OFF -DCONFIG_DSSI=OFF -DCONFIG_LV2=OFF cmake --build build --parallel $(nproc)Testing
1) Pressing record starts recording and playback
Steps:
Expected outcome:
2) Pressing record button during recording and playback stops recording and playback
Steps:
Expected outcome:
3) Pressing stop button during recording and playback stops recording and playback
Steps:
Expected outcome:
4) Pressing play button during recording and playback stops recording and playback
Steps:
Expected outcome: