Cache in GRADLE_HOME and cache JDKs by vendor#44
Open
hakanai wants to merge 2 commits into
Open
Conversation
Fixes issue rmee#35. Also: - Added vendor property so that the same version from two different vendors doesn't clash in the cache directory.
hakanai
commented
Feb 22, 2022
|
|
||
| public class JdkBootstrapExtension { | ||
|
|
||
| private String vendor; |
Contributor
Author
There was a problem hiding this comment.
One possible trap I can see with this is that adoptopenjdk is the default in the constructor - so if someone calls setUrlTemplate, they might forget to also set a vendor. Do we want to automatically set it to "unknown" or something if they call that?
I'd also have to update the other PR to set the vendor to "temurin" when this gets merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building on top of the Windows batch file PR, but adding:
With this I think all the customisations we had done to our own wrappers are covered, but I do wonder whether a cleaner way to patch the files after this plugin patches them would be nice...