Skip to content

Polymorphic collection and collection change detection improvements #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rko281 merged 4 commits into from
Feb 11, 2026
Merged

Polymorphic collection and collection change detection improvements #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
77e46d1
Fix issue retrieving polymorphic collections
rko281 Feb 4, 2026
add7015
Improved polymorphic collection fix. Contributes #7
rko281 Feb 6, 2026
412af64
Improved polymorphic collection fix - SQLite update.
rko281 Feb 6, 2026
0a0d779
Optimise collection change detection. Contributes to #8.
rko281 Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions ReStore/AbstractB.cls
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,30 @@
"Filed out from Dolphin Smallalk"!
"Filed out from Dolphin Smalltalk"!

AbstractA subclass: #AbstractB
instanceVariableNames: ''
instanceVariableNames: 'reference'
classVariableNames: ''
poolDictionaries: ''
classInstanceVariableNames: ''!

AbstractB guid: (GUID fromString: '{a925b7f2-6652-486f-8438-85177645d692}')!

AbstractB comment: ''!

!AbstractB categoriesForClass!Unclassified! !

!AbstractB methodsFor!

reference
^reference!

reference: anObject
reference := anObject! !

!AbstractB categoriesForMethods!
reference!accessing!private! !
reference:!accessing!private! !
!

!AbstractB class methodsFor!

addClassDefinitionToEmpty: aClassDef
Expand All @@ -21,6 +38,7 @@ reStoreDefinitionEmpty
shouldSubclassesInheritPersistencyFalse

^self ~~ ##(self)! !

!AbstractB class categoriesForMethods!
addClassDefinitionToEmpty:!public! !
reStoreDefinitionEmpty!public! !
Expand Down
8 changes: 7 additions & 1 deletion ReStore/ConcreteA.cls
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,26 @@
"Filed out from Dolphin Smallalk"!
"Filed out from Dolphin Smalltalk"!

AbstractB subclass: #ConcreteA
instanceVariableNames: 'a'
classVariableNames: ''
poolDictionaries: ''
classInstanceVariableNames: ''!

ConcreteA guid: (GUID fromString: '{63d5e45e-b7f4-477a-a90b-fa09627cae9c}')!

ConcreteA comment: ''!

!ConcreteA categoriesForClass!Unclassified! !

!ConcreteA class methodsFor!

reStoreDefinition

^super reStoreDefinition
define: #a as: String;
define: #reference as: ConcreteReferenceA;
yourself! !

!ConcreteA class categoriesForMethods!
reStoreDefinition!public! !
!
Expand Down
8 changes: 7 additions & 1 deletion ReStore/ConcreteB.cls
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,26 @@
"Filed out from Dolphin Smallalk"!
"Filed out from Dolphin Smalltalk"!

AbstractB subclass: #ConcreteB
instanceVariableNames: 'b'
classVariableNames: ''
poolDictionaries: ''
classInstanceVariableNames: ''!

ConcreteB guid: (GUID fromString: '{e57bf062-b41d-4043-947f-795c9fde9b3b}')!

ConcreteB comment: ''!

!ConcreteB categoriesForClass!Unclassified! !

!ConcreteB class methodsFor!

reStoreDefinition

^super reStoreDefinition
define: #b as: String;
define: #reference as: ConcreteReferenceB;
yourself! !

!ConcreteB class categoriesForMethods!
reStoreDefinition!public! !
!
Expand Down
39 changes: 39 additions & 0 deletions ReStore/ConcreteReferenceA.cls
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
"Filed out from Dolphin Smalltalk"!

Object subclass: #ConcreteReferenceA
instanceVariableNames: 'name'
classVariableNames: ''
poolDictionaries: ''
classInstanceVariableNames: ''!

ConcreteReferenceA guid: (GUID fromString: '{a2655220-0fab-450d-870d-04118189070b}')!

ConcreteReferenceA comment: ''!

!ConcreteReferenceA categoriesForClass!Unclassified! !

!ConcreteReferenceA methodsFor!

name
^name!

name: anObject
name := anObject! !

!ConcreteReferenceA categoriesForMethods!
name!accessing!private! !
name:!accessing!private! !
!

!ConcreteReferenceA class methodsFor!

reStoreDefinition

^super reStoreDefinition
define: #name as: (String maxSize: 100);
yourself! !

!ConcreteReferenceA class categoriesForMethods!
reStoreDefinition!public! !
!

39 changes: 39 additions & 0 deletions ReStore/ConcreteReferenceB.cls
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
"Filed out from Dolphin Smalltalk"!

Object subclass: #ConcreteReferenceB
instanceVariableNames: 'number'
classVariableNames: ''
poolDictionaries: ''
classInstanceVariableNames: ''!

ConcreteReferenceB guid: (GUID fromString: '{0ea038f5-2e2e-44b1-a9bc-41837f4cf103}')!

ConcreteReferenceB comment: ''!

!ConcreteReferenceB categoriesForClass!Unclassified! !

!ConcreteReferenceB methodsFor!

number
^number!

number: anObject
number := anObject! !

!ConcreteReferenceB categoriesForMethods!
number!accessing!private! !
number:!accessing!private! !
!

!ConcreteReferenceB class methodsFor!

reStoreDefinition

^super reStoreDefinition
define: #number as: Integer;
yourself! !

!ConcreteReferenceB class categoriesForMethods!
reStoreDefinition!public! !
!

Loading