Conversation
brandur
force-pushed
the
brandur-start-successfully-even-on-partial-start
branch
from
d9bb962 to
63f1cda
Compare
This one's presented as an alternative to #1136. Basically, a current problem with the start/stop infrastructure is that in the event of a partial start where a service returns from its start function, but without `Stop` having been called on, we can get into a situation where the start/stop's `isRunning` flag is still set to true, and when the start/stop is started again, it'll fall through thinking it's already running. Here, we check for this condition on subsequent starts. If the `stopped` channel is non-nil but already closed, we reset all internal state including `isRunning` so the service can start again. To prove this works, I pull in the test case added in #1136 verbatim, and also add one more specific test in `start_stop_test.go` for a more precise version.
brandur
force-pushed
the
brandur-start-successfully-even-on-partial-start
branch
from
63f1cda to
a6b9abe
Compare
bgentry
approved these changes
Mar 26, 2026
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one's presented as an alternative to #1136. Basically, a current
problem with the start/stop infrastructure is that in the event of a
partial start where a service returns from its start function, but
without
Stophaving been called on, we can get into a situation wherethe start/stop's
isRunningflag is still set to true, and when thestart/stop is started again, it'll fall through thinking it's already
running.
Here, we check for this condition on subsequent starts. If the
stoppedchannel is non-nil but already closed, we reset all internal state
including
isRunningso the service can start again.To prove this works, I pull in the test case added in #1136 verbatim,
and also add one more specific test in
start_stop_test.gofor a moreprecise version.