Allow passing a custom validator instance#9
Merged
Conversation
Rework the internal validation logic so that a customized validator can be provided. This allows for custom types and validations to be registered for use within the framework. Custom validators are passed as part of MountOpts.
brandur
approved these changes
Mar 20, 2025
| MiddlewareStack *apimiddleware.MiddlewareStack | ||
| // Validator is the validator to use for this endpoint. If not specified, | ||
| // the default validator will be used. | ||
| Validator *validator.Validate |
Contributor
There was a problem hiding this comment.
The only thing is that it seems like a bit of a smell to have this configured on a per-endpoint basis. Very likely you'd want one custom validator that you're going to be using application-wide, and having to inject that into every single endpoint seems like a large-ish chore and would add quite a lot of visual noise to the definitions.
Contributor
Author
There was a problem hiding this comment.
Yes, the issue is there’s no global struct to keep it on. I will say in practice it turned out to not be bad because I’m reusing the same mount opts struct for all endpoints in each group (authenticated and not).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proof of concept which makes it possible to use custom types and validations within the framework. You may not love this if you're wanting to keep the usage of the validation library as an internal implementation detail which could be swapped out, though in its current state (with a global validator variable that's unexported in an internal package) you cannot register custom types or validations.
This PR reworks the internal validation logic so that a customized validator can be provided. This allows for custom types and validations to be registered for use within the framework. Custom validators are passed as part of
MountOpts.