Conversation
brandur
force-pushed
the
brandur-import
branch
3 times, most recently
from
92b0adf to
906b5d3
Compare
Contributor
Author
|
@bgentry Thoughts? |
brandur
added a commit
to riverqueue/riverui
that referenced
this pull request
Mar 9, 2025
Here, move the API framework, which is currently duplicated in two projects, over to its own repository so that we can reuse it between them. It's new home will be `riverapiframe` [1]. [1] riverqueue/apiframe#1
brandur
added a commit
to riverqueue/riverui
that referenced
this pull request
Mar 9, 2025
Here, move the API framework, which is currently duplicated in two projects, over to its own repository so that we can reuse it between them. It's new home will be `riverapiframe` [1]. [1] riverqueue/apiframe#1
bgentry
approved these changes
Mar 9, 2025
Contributor
bgentry
left a comment
bgentry
left a comment
There was a problem hiding this comment.
LGTM aside from possible naming ideas which I dropped in Slack, your call 🚀
apiendpoint/api_endpoint.go
Outdated
Comment on lines
1
to
2
| // Package apiendpoint provides a lightweight API framework for use with River | ||
| // UI. It lets API endpoints be defined, then mounted into an http.ServeMux. |
Contributor
There was a problem hiding this comment.
Can probably drop the river UI reference and generalize this description.
Contributor
|
@brandur oh, you probably want to throw an MIT license on this too |
Here, import the framework code from the River UI project at [1]. I've added some READMEs, configuration files, etc., but otherwise very little has changed. There are a couple small things like adding `printf` variants for errors (which we'll need for Go 1.24 because it doesn't let you pass only a message to a printf-like function, and removing errors for specific types like jobs/queues/workflows (those will like in River UI instead). [1] https://github.com/riverqueue/riverui/tree/master/internal
Contributor
Author
Cool, done. Also renamed the repo to just "apiframe". |
brandur
added a commit
that referenced
this pull request
Mar 10, 2025
Corrects a few straggling problems with the rename done in #1. CI still passed there, so I thought I'd gotten everything, but didn't.
brandur
added a commit
that referenced
this pull request
Mar 10, 2025
Corrects a few straggling problems with the rename done in #1. CI still passed there, so I thought I'd gotten everything, but didn't.
brandur
added a commit
that referenced
this pull request
Mar 10, 2025
Corrects a few straggling problems with the rename done in #1. CI still passed there, so I thought I'd gotten everything, but didn't.
brandur
added a commit
to riverqueue/riverui
that referenced
this pull request
Mar 10, 2025
Here, move the API framework, which is currently duplicated in two projects, over to its own repository so that we can reuse it between them. It's new home will be `riverapiframe` [1]. [1] riverqueue/apiframe#1
brandur
added a commit
to riverqueue/riverui
that referenced
this pull request
Mar 10, 2025
Here, move the API framework, which is currently duplicated in two projects, over to its own repository so that we can reuse it between them. It's new home will be `riverapiframe` [1]. [1] riverqueue/apiframe#1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here, import the framework code from the River UI project at [1].
I've added some READMEs, configuration files, etc., but otherwise very
little has changed. There are a couple small things like adding
printfvariants for errors (which we'll need for Go 1.24 because it doesn't let
you pass only a message to a printf-like function, and removing errors
for specific types like jobs/queues/workflows (those will like in River
UI instead).
[1] https://github.com/riverqueue/riverui/tree/master/internal