Skip to content

Conversation

@SierraTran
Copy link
Contributor

Closes: #875

@SierraTran SierraTran linked an issue Dec 2, 2025 that may be closed by this pull request
@SierraTran SierraTran self-assigned this Dec 2, 2025
@SierraTran
Copy link
Contributor Author

SierraTran commented Dec 2, 2025

Should I make the publish/hide buttons update automatically (w/o refreshing the page) based on the status of the module? I would have to use the <Button> components instead of the ones from /common and use useMutation() in EditModulePage.tsx.

Also, clicking the publish button doesn't kick me out of the editor. Is it supposed to kick me out? I figured not since the save button already does that.

@SierraTran SierraTran marked this pull request as ready for review December 2, 2025 20:20
@ZZwatermelon
Copy link
Contributor

Should I make the publish/hide buttons update automatically (w/o refreshing the page) based on the status of the module? I would have to use the <Button> components instead of the ones from /common and use useMutation() in EditModulePage.tsx.

Also, clicking the publish button doesn't kick me out of the editor. Is it supposed to kick me out? I figured not since the save button already does that.

  1. Yes, that would be good. I personally don't like the very specific button components we have in /common anyway.
  2. I would say no, realistically the save button shouldn't kick you out either. I believe it does it because the system was implemented before we properly understood how to use refetch queries and such to make sure the information on the page was accurate. So kicking you out of the editor guaranteed that it would refetch the data if you navigated back to it.

@SierraTran SierraTran marked this pull request as draft December 3, 2025 17:44
@SierraTran SierraTran marked this pull request as ready for review December 4, 2025 17:12
@SierraTran SierraTran merged commit bcc7ecc into main Dec 11, 2025
1 check passed
@SierraTran SierraTran deleted the SierraTran/publish-saves-trainings branch December 11, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Publish" should imply save trainings

3 participants