Skip to content

Conversation

@SierraTran
Copy link
Contributor

Closes: #993
Closes: #994

@SierraTran SierraTran self-assigned this Nov 21, 2025
@SierraTran
Copy link
Contributor Author

SierraTran commented Nov 21, 2025

I saw this TODO comment in the dashboard code about grabbing the archived field from the Makerspaces table and using that to filter them.

Screenshot 2025-11-21 145525

This filtering is automatically done in MakerspaceRepository.ts.

Screenshot 2025-11-21 145108

If someone (probably an admin) is working on an archived makerspace, should I make it visible to only them (and other admins)?

Admins can view archived and published makerspaces. Other user roles can only see published makerspaces.
@SierraTran SierraTran marked this pull request as ready for review November 24, 2025 14:42
@ZZwatermelon
Copy link
Contributor

If someone (probably an admin) is working on an archived makerspace, should I make it visible to only them (and other admins)?

I think admins & managers of that makerspace should be able to see it regardless of its archived status. Such that an admin can make an archived makerspace and assign a manager, then that manager can fill out the equipment & such before the makerspace is published by the admin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Archive / Publish Makerspaces Make the Delete Makerspace button actually delete makerspaces

3 participants