fix: check current state before toggling on Windows#14
Open
fasuizu-br wants to merge 1 commit intorisoflora:mainfrom
Open
fix: check current state before toggling on Windows#14fasuizu-br wants to merge 1 commit intorisoflora:mainfrom
fasuizu-br wants to merge 1 commit intorisoflora:mainfrom
Conversation
`set()` unconditionally sent a key press+release, which always toggled the lock key regardless of the requested state. This meant `enable()` could turn a key OFF if it was already ON, and `disable()` could turn it ON if already OFF. Now reads the current state via `GetKeyState` and only sends the toggle event when the current state differs from the desired one. Closes risoflora#13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #13
The
set()method unconditionally sent a key press + release viakeybd_event, which always toggled the lock key regardless of the requested state. Thestateparameter was completely ignored.This meant:
enable()could turn a key OFF if it was already ONdisable()could turn a key ON if it was already OFFset(key, Enabled)on an already-enabled key would disable itFix
Read the current state via
GetKeyStatebefore acting. Only send the toggle key event when the current state differs from the desired one — makingset()idempotent, matching the behavior on macOS (IOHIDSetModifierLockState) and Linux (XkbLockModifiers).Before
After
Test plan
cargo checkpasses (macOS — Windows code behindcfg(windows))LockKey::new().enable(CapitalLock)when CapsLock is already ON → stays ON (no toggle)LockKey::new().disable(CapitalLock)when CapsLock is already OFF → stays OFF (no toggle)