Open
Conversation
Owner
|
Hello @ret-1, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @riponazad ,
Thanks a lot for including the PyTorch implementation of TAPIR! It’s been really useful.
I ran into some issues while training and made a few changes to fix them (mainly related to tensor dimension ordering and coordinate format). These should solve the problems I faced, but since I haven’t explored the EchoTracker code in detail, I’m not sure if it will affect anything there.
btw, I also plan to create a new repo for a full training and inference pipeline of TAPIR based on your wonderful implementation ; )
Thanks again for the awesome work!