Skip to content

Improve return types with conditional statements #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lorenzolosa wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Improve return types with conditional statements #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/CountryLoader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class CountryLoader
*
* @throws CountryLoaderException
*
* @return Country|array
* @return ($hydrate is true ? Country : array)
*/
public static function country($code, $hydrate = true)
{
Expand All @@ -44,7 +44,7 @@ public static function country($code, $hydrate = true)
*
* @throws CountryLoaderException
*
* @return array
* @return ($hydrate is true ? array<string, Country> : array<string, array>)
*/
public static function countries($longlist = false, $hydrate = false)
{
Expand Down
4 changes: 2 additions & 2 deletions src/helpers.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* @param string $code
* @param bool $hydrate
*
* @return Country|array
* @return ($hydrate is true ? Country : array)
*/
function country($code, $hydrate = true)
{
Expand All @@ -28,7 +28,7 @@ function country($code, $hydrate = true)
* @param bool $longlist
* @param bool $hydrate
*
* @return array
* @return ($hydrate is true ? array<string, Country> : array<string, array>)
*/
function countries($longlist = false, $hydrate = false)
{
Expand Down