Skip to content

chore(lint): weekly black/isort/flake8 sweep #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ringo380 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore(lint): weekly black/isort/flake8 sweep #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions analyzer/test_analytics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"""Unit tests for analyzer.analytics (server-side GA4 Measurement Protocol)."""

from unittest.mock import patch, MagicMock
from unittest.mock import MagicMock, patch

from django.test import SimpleTestCase, override_settings

Expand Down Expand Up @@ -31,7 +31,9 @@ def test_returns_false_without_measurement_id(self):
class HappyPathTests(SimpleTestCase):
def test_sends_expected_shape(self):
mock_resp = MagicMock(status_code=204, text="")
with patch("analyzer.analytics.requests.post", return_value=mock_resp) as mock_post:
with patch(
"analyzer.analytics.requests.post", return_value=mock_resp
) as mock_post:
ok = send_ga4_event(
client_id="cid-1",
event_name="log_analysis_completed",
Expand All @@ -53,7 +55,9 @@ def test_sends_expected_shape(self):

def test_omits_user_id_when_not_provided(self):
mock_resp = MagicMock(status_code=200, text="")
with patch("analyzer.analytics.requests.post", return_value=mock_resp) as mock_post:
with patch(
"analyzer.analytics.requests.post", return_value=mock_resp
) as mock_post:
send_ga4_event("cid", "anon_event", {})
body = mock_post.call_args.kwargs["json"]
self.assertNotIn("user_id", body)
Expand Down
Loading