Skip to content

add option append_in_comment for show_in_comment#708

Open
shewer wants to merge 5 commits intorime:masterfrom
shewer:simplifier_patch1
Open

add option append_in_comment for show_in_comment#708
shewer wants to merge 5 commits intorime:masterfrom
shewer:simplifier_patch1

Conversation

@shewer
Copy link
Copy Markdown
Contributor

@shewer shewer commented Sep 6, 2023

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Describe feature of pull request

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

Signed-off-by: shewer <shewer@gmail.com>
Signed-off-by: shewer <shewer@gmail.com>
Signed-off-by: shewer <shewer@gmail.com>
Signed-off-by: shewer <shewer@gmail.com>
Copy link
Copy Markdown
Member

@lotem lotem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, PTAL

Comment thread src/rime/gear/simplifier.cc Outdated
Comment thread src/rime/gear/simplifier.cc Outdated
Comment thread src/rime/gear/simplifier.cc Outdated
Comment thread src/rime/gear/simplifier.h Outdated
Signed-off-by: Shewer Lu <shewer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants