Skip to content

Add toggle pagination support to games view #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaimegarjr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add toggle pagination support to games view #376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion Delta/Game Selection/GamesViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ class GamesViewController: UIViewController
private var pageViewController: UIPageViewController!
private var placeholderView: RSTPlaceholderView!
private var pageControl: UIPageControl!
private var lastSelectedPageIndex: Int = 0

private let fetchedResultsController: NSFetchedResultsController<NSFetchRequestResult>

Expand Down Expand Up @@ -114,6 +115,7 @@ extension GamesViewController

self.pageControl.centerXAnchor.constraint(equalTo: (self.navigationController?.toolbar.centerXAnchor)!, constant: 0).isActive = true
self.pageControl.centerYAnchor.constraint(equalTo: (self.navigationController?.toolbar.centerYAnchor)!, constant: 0).isActive = true
self.pageControl.addTarget(self, action: #selector(pageControlTapped(_:)), for: .valueChanged)

if let navigationController = self.navigationController
{
Expand Down Expand Up @@ -322,12 +324,14 @@ private extension GamesViewController
if let index = self.fetchedResultsController.fetchedObjects?.firstIndex(where: { $0 as! GameCollection == gameCollection })
{
self.pageControl.currentPage = index
self.lastSelectedPageIndex = index
}
else
{
resetPageViewController = true

self.pageControl.currentPage = 0
self.lastSelectedPageIndex = 0
}

}
Expand All @@ -353,6 +357,8 @@ private extension GamesViewController
index = gameCollectionIndex
}
}

self.lastSelectedPageIndex = index

if let viewController = self.viewControllerForIndex(index)
{
Expand Down Expand Up @@ -380,7 +386,18 @@ private extension GamesViewController
self.placeholderView.setHidden(false, animated: animated)
}
}


@objc func pageControlTapped(_ sender: UIPageControl) {
let direction: UIPageViewController.NavigationDirection = (sender.currentPage > self.lastSelectedPageIndex) ? .forward : .reverse
self.lastSelectedPageIndex = self.pageControl.currentPage

guard let nextViewController = self.viewControllerForIndex(sender.currentPage) else { return }
self.pageViewController.setViewControllers([nextViewController], direction: direction, animated: true) { [weak self] completed in
guard let self = self else { return }
self.pageViewController(self.pageViewController, didFinishAnimating: true, previousViewControllers: [nextViewController], transitionCompleted: true)
}
}

@objc func openFAQ()
{
let faqURL = URL(string: "https://faq.deltaemulator.com/getting-started/importing-games")!
Expand Down