Fix the crash of -[NSNull _fastCStringContents:]

[dreampiggy]

See: altstoreio/AltStore#157

[dreampiggy]

Some API break changes in the master vs the commit AltStore used. Please pay attention:

-- (instancetype)initWithName:(NSString *)name identifier:(NSString *)identifier NS_DESIGNATED_INITIALIZER;
+- (instancetype)initWithName:(NSString *)name identifier:(NSString *)identifier type:(ALTDeviceType)type NS_DESIGNATED_INITIALIZER;

[rileytestut]

Changing these property types from NSString (which it should be) to id doesn't really seem to address the underlying issue, which is that when parsing certificates the machineName and machineIdentifier keys might be "null" (from what I understand). Plus, this makes working with this library from Swift much more frustrating due to type erasure.

[dreampiggy]

This API is from Apple, they use NSNull. You have to do compatible hack...
If I'm the author of Apple's Private Framework, I will not use suck a hack logic (return NSNull instead of nil)

[rileytestut]

I understand, but it'd be better to update -[ALTCertificate initWithResponseDictionary:] to explicitly check for NULL values and assign nil instead to those properties, rather than assign the NSNull object directly and change the public API.

[dreampiggy]

Any update ?