Open
Conversation
onahprosper
reviewed
May 16, 2022
contracts/UserYieldFarming.sol
Outdated
| user.amount = user.amount.add(_amount); | ||
| pool.lpToken.safeTransferFrom(msg.sender, address(this), _amount); | ||
| uint256 userPct = ((_amount * 1.3E18) / 100E18); | ||
| uint256 newAmt = (_amount - userPct); |
Collaborator
There was a problem hiding this comment.
you should'nt remove 1.3% from all deposit, it should only have effect on external pool.
contracts/UserYieldFarming.sol
Outdated
| uint256 newAmt = (_amount - userPct); | ||
| user.amount = user.amount.add(newAmt); | ||
| } | ||
| if (pool.extPool == true) { |
Collaborator
There was a problem hiding this comment.
if (pool.extPool == true) can be changed to
if (pool.extPool) to reduce lines of codes
contracts/UserYieldFarming.sol
Outdated
| } | ||
| if (pool.extPool == true) { | ||
| uint256 userPct = ((_amount * 1.3E18) / 100E18); | ||
| pool.lpToken.safeTransferFrom(msg.sender, address(this), _amount); |
Collaborator
There was a problem hiding this comment.
this will cause multiple withdrawal from a user using external pools kindly delete this line.
pool.lpToken.safeTransferFrom(msg.sender, address(this), _amount);
onahprosper
reviewed
May 17, 2022
contracts/UserYieldFarming.sol
Outdated
| pool.lpToken.safeTransferFrom(address(msg.sender), address(this), _amount); | ||
| pool.lpToken.safeTransferFrom(msg.sender, address(this), _amount); | ||
| if (pool.extPool) { | ||
| uint256 userPct = ((_amount * 1.3E18) / 100E18); |
Collaborator
There was a problem hiding this comment.
Safemath usage consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.