Conversation
This commit doesn't address dead-code warnings, as this is a WIP branch. When the branch is ready for the PR, the dead/unused code can be reviewed
| device_major(dev) | ||
| libc::major(dev) | ||
| } | ||
|
|
||
| #[cfg(not(target_os = "macos"))] | ||
| fn device_minor(dev: u64) -> u32 { | ||
| device_minor(dev) |
There was a problem hiding this comment.
The only part that changes logic. @Zorlin please confirm?
There was a problem hiding this comment.
@Zorlin is that something you'd like to delegate to me?
There was a problem hiding this comment.
Hi, reply by email didn't seem to work
We don't want any libc functions in the codebase as it makes musl builds near impossible
There was a problem hiding this comment.
I've reverted that change, and will look into moving to musl in another branch.
If I run cargo test, it fails on dragonfly not being installed. assuming that test works on your machine, it should be good to go: If I did my job right, there isn't any changes to logic.
There was a problem hiding this comment.
Alrighty! Appreciate it. This will likely need to be rebased for v0.1.0.
|
Libc is out. We need musl builds.
…On Tue, 13 Jan 2026, 22:54 Ben, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In patches/proxmox-compression/src/tar.rs
<#2 (comment)>:
> - device_major(dev)
+ libc::major(dev)
}
#[cfg(not(target_os = "macos"))]
fn device_minor(dev: u64) -> u32 {
- device_minor(dev)
The only part that changes logic. @Zorlin <https://github.com/Zorlin>
please confirm?
—
Reply to this email directly, view it on GitHub
<#2 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKONLHPOP6PTCTG6IMLDRD4GUBLHAVCNFSM6AAAAACRRVXM62VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMNJWGI2TCNJZG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Ben-PH
changed the title
Ben-PH
changed the title
2 participants
This commit doesn't address dead-code warnings, as this is a WIP branch. When the branch is ready for the PR, the dead/unused code can be reviewed