Updated Base PageModel to have an InitAsync method#320
Open
killer-frog wants to merge 1 commit intorid00z:masterfrom
Open
Updated Base PageModel to have an InitAsync method#320killer-frog wants to merge 1 commit intorid00z:masterfrom
killer-frog wants to merge 1 commit intorid00z:masterfrom
Conversation
Contributor
Author
|
@rid00z Any thoughts on this change? I might have to update the readme, but I thought it would be a useful addition |
|
@rid00z Bump, because I agree that this is a really good idea |
|
any chance to get this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added InitAsync to base page model so that it is properly async.
Consolidated the version of Xamarin forms as the version in the test project was a major version behind.
Added async through the call stack and updated unit tests to be async